fixes for k8s deploy scripts #35
Conversation
| @@ -76,7 +76,7 @@ | |||
| ports: | |||
| - "5000:5000" | |||
| volumes: | |||
| - ../registry.config.yml:/etc/docker/registry/config.yml | |||
There was a problem hiding this comment.
I believe this change will disable the cleanup/delete capability on the local registry. The delete option is enabled in the registry.config.yml file on line 10 & 11.
There was a problem hiding this comment.
hi I don't quite understand the comment. overall, I faced issue to map a file in volumes section, so I create a registry folder with config.yml in local folder and mount the folder into /etc/docker/ under this volumes section
There was a problem hiding this comment.
i see.. somehow on my side i was able to run this previously. noted on this.
if this is the case, could you also commit and push in the registry folder with the config.yml under setup-scripts/setup-onpremise-kubernetes directory. Since the registry.config.yml is deleted would like to have it maintained under setup-scripts/setup-onpremise-kubernetes/registry/config.yaml
There was a problem hiding this comment.
@wanhakim yes. my bad to miss that file. added it back under the new registry folder.
Signed-off-by: Tsai, Louie <[email protected]>
some issues block k8s deployment, and 1 or 2 issues like args : warn related to ansible version.