✨ Add an IgnoreFields option to select whether to override resource by mw #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The option is to disable overrid resource on the spoke by manifestwork when the resource is changed by another actor on the spoke Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
mw-update-strategy
branch
from
26ec0c7 to
f777e4a
Compare
qiujian16
force-pushed
the
mw-update-strategy
branch
3 times, most recently
from
3d53e1d to
dc501bb
Compare
qiujian16
changed the title
zhujian7
reviewed
Nov 26, 2024
| Condition IgnoreFieldsCondition `json:"condition"` | ||
|
|
||
| // JSONPaths defines the list of json path in the resource to be ignored | ||
| JSONPaths []string `json:"jsonPaths"` |
There was a problem hiding this comment.
should this be a required field? if it is empty, what should we do?
There was a problem hiding this comment.
I do not think list can be required, but we could set the minItem to 1
Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
mw-update-strategy
branch
from
dc501bb to
1d0a8b8
Compare
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 05ff7c1
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is to disable override resource on the spoke by manifestwork when the resource is changed by another actor on the spoke
Summary
Related issue(s)
Fixes #