-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Updated clustermanager API spec and generated files for spec change. #355
Changes from 1 commit
3f8f9d9
9c4a71e
38bb925
c691e21
10c2d55
8f899ea
3eaf176
2c57e6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,6 +108,19 @@ type RegistrationHubConfiguration struct { | |
// he can set featuregate/Foo=false before upgrading. Let's say the cluster-admin wants featuregate/Foo=false. | ||
// +optional | ||
FeatureGates []FeatureGate `json:"featureGates,omitempty"` | ||
|
||
// This provides details to initialize Hub cluster | ||
// +optional | ||
RegistrationDriverHub RegistrationDriverHub `json:"registrationDriverHub,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can call it authDriver or registrationDriver. Also I think this should be a list, we should be able to support multiple drivers at the same time on hub. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated with the suggestions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you make this as registrationDrivers []RegistrationDriver There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have another struct with name RegistrationDriver in types_klusterlet.go. That is the reason it was initially named it as RegistrationDriverHub. So can we go with the second option that you had suggested which is authDriver? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is ok that the struct name is RegistrationDriverHub, but let's make the field name to be registrationDrivers and make it as a slice. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed to registrationDrivers and it was already changed to a slice in previous commit |
||
} | ||
|
||
type RegistrationDriverHub struct { | ||
|
||
// Type of the authentication used by hub to initialize the Hub cluster. Possible values are csr and awsirsa. | ||
// +required | ||
// +kubebuilder:default:=csr | ||
// +kubebuilder:validation:Enum=csr;awsirsa | ||
AuthType string `json:"authType,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. one minor comment, we should add // +listType=map |
||
} | ||
|
||
type WorkConfiguration struct { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment needs to be updated, it is not clear what this drivers meant to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the comment to give more clarity