update placement doc #79
Conversation
|
/assign @qiujian16 |
elgnay
force-pushed
the
update-placement-doc
branch
from
6d86cfb to
b90308d
Compare
Signed-off-by: Yang Le <[email protected]>
elgnay
force-pushed
the
update-placement-doc
branch
from
b90308d to
05c4bd1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elgnay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // A placement is not satisfied if | ||
| // 1) No ManagedClusterSetBinding is found in the placement namespace; | ||
| // 2) ClusterSets in spec is specified and none of them is bound to the placement namespace; | ||
| // 3) No memeber ManagedCluster is found for all eligible ManagedClusterSets; A ManagedClusterSet |
There was a problem hiding this comment.
There is no ManagedCluster in the ManagedClusterSets specified in the spec. And I do not think you need a and b
There was a problem hiding this comment.
There is no ManagedCluster in the ManagedClusterSets specified in the spec. And I do not think you need a and b
The above description does not cover the case: placement without Clustersets specified in the spec.
There was a problem hiding this comment.
Would you like to update a bit on this description?
I think it will be
1) No ManagedClusterSetBinding in the Placement namespace;
2) ClusterSets in the Placement spec is specified and none of them is bound to the namespace of the Placement;
3) No ManagedCluster in the ClusterSets which are specified in the Placement spec or bound to this namespace if ClusterSets is not specified in the Placement spec.
4) No ManagedCluster matches any of the cluster predicates in the Placement spec;
5) NumberOfSelectedClusters in status is less than NumberOfClusters in the Placement spec if it is specified;
|
@elgnay: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yang Le [email protected]