Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --replace flag #151

Conversation

ycyaoxdu
Copy link
Member

@ycyaoxdu ycyaoxdu commented Mar 10, 2022

add one cluster in clusterset1 to clusterset2 (by overwrite)

this can be regarded as remove+add

Signed-off-by: ycyaoxdu [email protected]

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 March 10, 2022 03:38
@ycyaoxdu
Copy link
Member Author

test output:

╰─$ clusteradm clusterset add set1 --clusters cluster1                                                                                                                 1 
Cluster cluster1 is already added into Clusterset set2, you can't add it to set1

╰─$ clusteradm clusterset add set1 --replace --clusters cluster1
Cluster cluster1 is added into Clusterset set1

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 29969eb into open-cluster-management-io:main Mar 10, 2022
@ycyaoxdu ycyaoxdu deleted the fix/add-flag-replace branch March 15, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants