Skip to content

Commit

Permalink
uprade supported kueue version to v0.9.1
Browse files Browse the repository at this point in the history
Signed-off-by: Qing Hao <[email protected]>
  • Loading branch information
haoqing0110 committed Dec 6, 2024
1 parent a967216 commit 37b6a91
Show file tree
Hide file tree
Showing 11 changed files with 197 additions and 284 deletions.
18 changes: 1 addition & 17 deletions solutions/kueue-admission-check/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ REF: [Setup a MultiKueue environment](https://kueue.sigs.k8s.io/docs/tasks/manag
2. [Kueue](https://kueue.sigs.k8s.io/docs/installation/) deployed across all clusters.
3. [Managed-serviceaccount](https://github.com/open-cluster-management-io/managed-serviceaccount), [cluster-permission](https://github.com/open-cluster-management-io/cluster-permission) and [resource-usage-collect-addon](https://github.com/open-cluster-management-io/addon-contrib/tree/main/resource-usage-collect-addon) installed on managed clusters.



- You can set up these above by running the command:
```bash
./setup-env.sh
Expand Down Expand Up @@ -624,18 +622,4 @@ spec:
- Finally, it updates the AdmissionCheck condition to true, indicating successful generation of the `MultiKueueConfig` and `MultiKueueCluster`, readying the [MultiKueue](https://kueue.sigs.k8s.io/docs/concepts/multikueue/) environment for job scheduling.

## TODO
- In the future, the `AdmissionCheckcontroller` may be added to `featureGates` as a user-enabled feature or possibly developed into an individual component running as a pod on the `hub`.
- Users may also need to enable the `ClusterProfile` feature in the `featureGates` to utilize the OCM Admission Check. This can be done by configuring the `ClusterManager` in `hub`.
```yaml
apiVersion: operator.open-cluster-management.io/v1
kind: ClusterManager
metadata:
name: cluster-manager
spec:
registrationConfiguration:
featureGates:
- feature: ClusterProfile
mode: Enable
...
```

- In the future, the `AdmissionCheckcontroller` may be added to `featureGates` as a user-enabled feature or possibly developed into an individual component running as a pod on the `hub`.
144 changes: 144 additions & 0 deletions solutions/kueue-admission-check/env/clusterpermission.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
# the permission is copied from https://kueue.sigs.k8s.io/docs/tasks/manage/setup_multikueue/
apiVersion: rbac.open-cluster-management.io/v1alpha1
kind: ClusterPermission
metadata:
name: kueue-admin-CLUSTER_NAME
namespace: CLUSTER_NAME
spec:
clusterRole:
rules:
- apiGroups:
- batch
resources:
- jobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- batch
resources:
- jobs/status
verbs:
- get
- apiGroups:
- jobset.x-k8s.io
resources:
- jobsets
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- jobset.x-k8s.io
resources:
- jobsets/status
verbs:
- get
- apiGroups:
- kueue.x-k8s.io
resources:
- workloads
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kueue.x-k8s.io
resources:
- workloads/status
verbs:
- get
- patch
- update
- apiGroups:
- kubeflow.org
resources:
- tfjobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
- tfjobs/status
verbs:
- get
- apiGroups:
- kubeflow.org
resources:
- paddlejobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
- paddlejobs/status
verbs:
- get
- apiGroups:
- kubeflow.org
resources:
- pytorchjobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
- pytorchjobs/status
verbs:
- get
- apiGroups:
- kubeflow.org
resources:
- xgboostjobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
- xgboostjobs/status
verbs:
- get
- apiGroups:
- kubeflow.org
resources:
- mpijobs
verbs:
- create
- delete
- get
- list
- watch
- apiGroups:
- kubeflow.org
resources:
- mpijobs/status
verbs:
- get
clusterRoleBinding:
subject:
kind: ServiceAccount
name: kueue-admin-CLUSTER_NAME
namespace: open-cluster-management-agent-addon
63 changes: 0 additions & 63 deletions solutions/kueue-admission-check/env/cp-c1.yaml

This file was deleted.

63 changes: 0 additions & 63 deletions solutions/kueue-admission-check/env/cp-c2.yaml

This file was deleted.

63 changes: 0 additions & 63 deletions solutions/kueue-admission-check/env/cp-c3.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions solutions/kueue-admission-check/env/msa-c1.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions solutions/kueue-admission-check/env/msa-c3.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: authentication.open-cluster-management.io/v1beta1
kind: ManagedServiceAccount
metadata:
name: kueue-admin-cluster2
namespace: cluster2
name: kueue-admin-CLUSTER_NAME
namespace: CLUSTER_NAME
spec:
rotation: {}
Loading

0 comments on commit 37b6a91

Please sign in to comment.