🌱 upgrade sdk-go #498
🌱 upgrade sdk-go #498
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 62.13% 62.10% -0.03%
==========================================
Files 140 140
Lines 11764 11773 +9
==========================================
+ Hits 7309 7312 +3
- Misses 3683 3689 +6
Partials 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
go.mod
Outdated
| @@ -36,7 +36,7 @@ require ( | |||
| k8s.io/utils v0.0.0-20240310230437-4693a0247e57 | |||
| open-cluster-management.io/addon-framework v0.9.1-0.20240419070222-e703fc5a2556 | |||
| open-cluster-management.io/api v0.13.1-0.20240521030453-9d94703b9eba | |||
| open-cluster-management.io/sdk-go v0.13.1-0.20240520073308-f18d198a844d | |||
| open-cluster-management.io/sdk-go v0.13.1-0.20240605032202-2a0633ddf34e | |||
There was a problem hiding this comment.
@skeeey please update to latest commit: open-cluster-management-io/sdk-go@874c2c7
there should no code change for your PR, just upgrade the dependency to get this fix: open-cluster-management-io/sdk-go#52
skeeey
force-pushed
the
upgrade-sdk
branch
2 times, most recently
from
cbf3c46 to
9c9c99a
Compare
|
/assign @qiujian16 |
| @@ -278,8 +278,8 @@ func CreateManifestWork(mwrSet *workapiv1alpha1.ManifestWorkReplicaSet, clusterN | |||
| ManifestWorkReplicaSetPlacementNameLabelKey: placementRefName, | |||
| }, | |||
| Annotations: map[string]string{ | |||
| common.CloudEventsDataTypeAnnotationKey: payload.ManifestBundleEventDataType.String(), | |||
| common.CloudEventsGenerationAnnotationKey: fmt.Sprintf("%d", mwrSet.Generation), | |||
| common.CloudEventsDataTypeAnnotationKey: payload.ManifestBundleEventDataType.String(), | |||
There was a problem hiding this comment.
could you explain why these annotation is needed? should it be optionally set?
There was a problem hiding this comment.
add the comments, these are only needed by cloudevents client
There was a problem hiding this comment.
only add them when cloudevents client is used
skeeey
force-pushed
the
upgrade-sdk
branch
3 times, most recently
from
8e3d0cf to
b93be12
Compare
Signed-off-by: Wei Liu <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 61a74bb
into
open-cluster-management-io:main
Signed-off-by: Wei Liu <[email protected]>
Summary
Related issue(s)
Fixes #