Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ignore field should not be honored when creating the resource #784

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and zhujian7 January 2, 2025 01:36
@openshift-ci openshift-ci bot added the approved label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (0007cd4) to head (0e11b53).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/work/spoke/apply/server_side_apply.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
+ Coverage   63.77%   63.80%   +0.02%     
==========================================
  Files         192      192              
  Lines       18596    18606      +10     
==========================================
+ Hits        11860    11871      +11     
  Misses       5757     5757              
+ Partials      979      978       -1     
Flag Coverage Δ
unit 63.80% <94.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

/assign @zhujian7

@zhujian7
Copy link
Member

zhujian7 commented Jan 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 037aa3c into open-cluster-management-io:main Jan 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants