Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

471 environmental measures #476

Merged
merged 8 commits into from
Feb 16, 2024
Merged

471 environmental measures #476

merged 8 commits into from
Feb 16, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Feb 6, 2024

Related issues

closes #471

Description

Merge checklist

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@odscjen odscjen marked this pull request as ready for review February 10, 2024 16:49
@odscjen odscjen requested a review from neelima-j February 10, 2024 16:49
Copy link
Contributor

@neelima-j neelima-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'environmentalMeasures' to be added to documentType
  • Other changes suggested to match issue discussion.

@odscjen odscjen requested a review from jpmckinney February 15, 2024 12:06
@odscjen
Copy link
Contributor Author

odscjen commented Feb 15, 2024

@jpmckinney this should be the final PR for changes to 0.9.4. Once this is merged we can merge 0.9-dev into 0.9 and then make a start on the Spanish translation of the new bits.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to make the codelist and schema easier to read.

@odscjen
Copy link
Contributor Author

odscjen commented Feb 16, 2024

Thanks @jpmckinney I've made those updates, is this ok to merge now?

@jpmckinney jpmckinney merged commit 5ee80b9 into 0.9-dev Feb 16, 2024
10 checks passed
@jpmckinney jpmckinney deleted the 471_environmental_measures branch February 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environmental measures: new object and codelist
3 participants