Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use TEST_PASSWORD variable in tests + quince & palm as test targets #33

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Nov 4, 2023

Description
The integration tests are failing due to a change in the UserFactory's default password.
This MR addresses that by relying on a variable available in the factories module.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@CefBoud CefBoud force-pushed the CefBoud/variablize-password-in-tests branch 2 times, most recently from e65e326 to 9bdeb29 Compare November 4, 2023 14:29
@CefBoud CefBoud changed the title fix: use _DEFAULT_PASSWORD variable in tests fix: use TEST_PASSWORD variable in tests Nov 4, 2023
@CefBoud CefBoud force-pushed the CefBoud/variablize-password-in-tests branch 4 times, most recently from 36b05eb to 991299b Compare November 4, 2023 15:41
@CefBoud CefBoud changed the title fix: use TEST_PASSWORD variable in tests fix: use TEST_PASSWORD variable in tests + quince & palm as test targets Nov 4, 2023
@CefBoud CefBoud force-pushed the CefBoud/variablize-password-in-tests branch 2 times, most recently from 92b915e to 3c04a22 Compare November 4, 2023 16:35
@Agrendalath Agrendalath force-pushed the CefBoud/variablize-password-in-tests branch from 235fc6f to 7c3f251 Compare November 7, 2023 18:20
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the CI is passing for all releases
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath Agrendalath enabled auto-merge November 7, 2023 18:24
@Agrendalath Agrendalath merged commit ad306ee into main Nov 7, 2023
8 checks passed
@Agrendalath Agrendalath deleted the CefBoud/variablize-password-in-tests branch November 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants