Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#5016] Referentielijsten dataSrc for options #204

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 14, 2025

closes open-formulieren/open-forms#5016 partially

Requires open-formulieren/types#64 to be merged and released

@stevenbal stevenbal marked this pull request as draft January 14, 2025 15:56
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch 2 times, most recently from e462b1c to cb70661 Compare January 24, 2025 15:22
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch 5 times, most recently from 2a6c27b to 75b0595 Compare January 28, 2025 12:47
@stevenbal stevenbal changed the title 🚧 [#5016] Referentielijsten dataSrc for options ✨ [#5016] Referentielijsten dataSrc for options Jan 28, 2025
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch 3 times, most recently from d99a9a9 to 7b6225b Compare February 3, 2025 14:09
@stevenbal stevenbal marked this pull request as ready for review February 3, 2025 14:47
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch from 7b6225b to c94af28 Compare February 4, 2025 09:16
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments on stories/implementation for radio obviously also apply to select and selectboxes :)

src/utils/storybookTestHelpers.d.ts Outdated Show resolved Hide resolved
src/components/builder/values/referentielijsten/code.tsx Outdated Show resolved Hide resolved
src/components/builder/values/referentielijsten/code.tsx Outdated Show resolved Hide resolved
src/components/builder/values/referentielijsten/code.tsx Outdated Show resolved Hide resolved
src/registry/radio/radio-referentielijsten.stories.ts Outdated Show resolved Hide resolved
src/registry/radio/radio-referentielijsten.stories.ts Outdated Show resolved Hide resolved
src/registry/radio/radio-referentielijsten.stories.ts Outdated Show resolved Hide resolved
src/registry/radio/radio-referentielijsten.stories.ts Outdated Show resolved Hide resolved
src/registry/select/edit-validation.ts Show resolved Hide resolved
… custom helper

selectEvent from react-select-event was causing issues when used with a storybook production build
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch 2 times, most recently from 2752021 to 30e3919 Compare February 4, 2025 11:32
@stevenbal stevenbal force-pushed the feature/5016-data-source-referentielijsten branch from 30e3919 to c1ef2f9 Compare February 4, 2025 11:54
@@ -16,6 +16,7 @@
"noImplicitAny": true,
"strictBindCallApply": true,
"strictNullChecks": true,
"skipLibCheck": true,
Copy link
Member

@sergei-maertens sergei-maertens Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a follow up issue to enable this again and assign it to me? I don't want to forget about it and am usually hesitant to disable type checking features 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an extra data source option (Referentielijsten API) on the basic tab
2 participants