Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5077] Improve performance in loading logic rules in admin #5078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 4, 2025

Closes #5077

Changes

  • Logic rules list in the admin was really slow as the logic rules increase because of the same queries happening for the form and the form step. Some joins were added in order to reduce the amount of the queries.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft February 4, 2025 13:04
@vaszig
Copy link
Contributor Author

vaszig commented Feb 4, 2025

Before:

logic-rules-performance-old

After:

logic-rules-performance-new

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (3f79ba2) to head (45b71ff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5078   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files         770      770           
  Lines       26517    26517           
  Branches     3454     3454           
=======================================
  Hits        25649    25649           
  Misses        606      606           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as ready for review February 4, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of loading logic rules in admin
1 participant