Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collate dbt parser #1

Merged
merged 6 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 yu-iskw
# Copyright 2024
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
sleep 30
- name: Install package
run: |
python3 -m pip install -U dbt-artifacts-parser
python3 -m pip install -U collate-dbt-artifacts-parser
- name: Test package
run: |
python -c 'import dbt_artifacts_parser; print(dbt_artifacts_parser.__version__)'
python -c 'import collate_dbt_artifacts_parser; print(collate_dbt_artifacts_parser.__version__)'
8 changes: 4 additions & 4 deletions .github/workflows/test-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: Test publish (testpypi)
on:
workflow_dispatch:
inputs:
dbt_artifacts_parser_version:
description: "dbt-artifacts-parser version"
collate_dbt_artifacts_parser_version:
description: "collate-dbt-artifacts-parser version"
required: true

jobs:
Expand Down Expand Up @@ -52,11 +52,11 @@ jobs:
--extra-index-url https://pypi.org/simple/ \
--force-reinstall \
--use-feature=fast-deps \
-U dbt-artifacts-parser=="${{ github.event.inputs.dbt_artifacts_parser_version }}"
-U collate-dbt-artifacts-parser=="${{ github.event.inputs.collate_dbt_artifacts_parser_version }}"
# It takes some time when the package gets available.
- name: Sleep
run: |
sleep 30
- name: Test package
run: |
python -c 'import dbt_artifacts_parser; print(dbt_artifacts_parser.__version__)'
python -c 'import collate_dbt_artifacts_parser; print(collate_dbt_artifacts_parser.__version__)'
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
paths:
- .github/workflows/test.yml
- 'pyproject.toml'
- 'dbt_artifacts_parser/**/*.py'
- 'collate_dbt_artifacts_parser/**/*.py'
- 'tests/**/*.py'
- 'pylintrc'
push:
Expand Down Expand Up @@ -42,4 +42,4 @@ jobs:
- name: Test installation
run: |
pip install -e .
python -c 'import dbt_artifacts_parser'
python -c 'import collate_dbt_artifacts_parser'
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ MANIFEST
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec
!dbt_artifacts_parser/parsers/manifest
!dbt_artifacts_parser/resources/manifest
!collate_dbt_artifacts_parser/parsers/manifest
!collate_dbt_artifacts_parser/resources/manifest

# Installer logs
pip-log.txt
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ These are the steps to generate the Pydantic models from dbt artifacts in this p
2. Generate Pydantic models from the JSON schemas

We get JSON schemas of dbt artifacts which we want to add or update from the repository of [dbt-core](https://github.com/dbt-labs/dbt-core/tree/main/schemas/dbt).
We manage the downloaded JSON schemas in the directory of [dbt_artifacts_parser/resources/](./dbt_artifacts_parser/resources/).
We manage the downloaded JSON schemas in the directory of [collate_dbt_artifacts_parser/resources/](./collate_dbt_artifacts_parser/resources/).

[dev/generate_parser_classes.sh](./dev/generate_parser_classes.sh) is a script to generate Pydantic models from the JSON schemas of dbt artifacts.
If we want to add new dbt artifact(s), we need to modify the script to generate the new pydantic models.
Loading
Loading