Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null value secrets #204

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

preetsshah
Copy link
Contributor

@preetsshah preetsshah commented Dec 19, 2023

Describe your changes :

We have been reported with an issue with the new helm chart (OMD app version - 1.2.3 and Chart version - 1.2.5)

Apparently, when the "hostIp" value is kept empty (or "") in the values.yaml file, the secrets template creates a null value secret for it which results in error while upgrading/installing the newer version of the helm chart.

With these changes, secret for hostIP won't be created unless it is non-empty.

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@akash-jain-10

@preetsshah preetsshah marked this pull request as ready for review December 20, 2023 10:52
@akash-jain-10 akash-jain-10 merged commit a1cbfb5 into open-metadata:main Jan 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants