Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
We have been reported with an issue with the new helm chart (OMD app version - 1.2.3 and Chart version - 1.2.5)
Apparently, when the "hostIp" value is kept empty (or "") in the values.yaml file, the secrets template creates a null value secret for it which results in error while upgrading/installing the newer version of the helm chart.
With these changes, secret for hostIP won't be created unless it is non-empty.
Type of change :
Checklist:
Reviewers
@akash-jain-10