Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added annotations #281

Merged
merged 4 commits into from
Dec 10, 2024
Merged

feat: added annotations #281

merged 4 commits into from
Dec 10, 2024

Conversation

safayavatsal
Copy link
Contributor

@safayavatsal safayavatsal commented Nov 26, 2024 •
edited
Loading

What this PR does / why we need it :

Fixes #243

Added the following requirements -

  • artifacthub.io/images
  • artifacthub.io/license (https://choosealicense.com/licenses/apache-2.0/)
  • artifacthub.io/prerelease
  • artifacthub.io/recommendations (For the dependencies of bitnami/mysql , airflow and opensearch
  • artifacthub.io/containsSecurityUpdates
  • support (Pointing to our github issues of Helm Chart)
  • kubeVersion (We support Kubernetes Version >=1.24)

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@safayavatsal safayavatsal marked this pull request as ready for review November 26, 2024 07:42
@safayavatsal safayavatsal mentioned this pull request Nov 26, 2024
Closed
7 tasks
@safayavatsal
Copy link
Contributor Author

made required changes in image annotations.

akash-jain-10
akash-jain-10 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@tutte tutte merged commit b276fe1 into open-metadata:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ArtifactHub Chart Annotations for capturing meta information
3 participants
@safayavatsal @tutte @akash-jain-10