-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Librilight Preprocess Scripts Revision #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts. Please check the comments.
or not os.path.exists(mfa_model_path) | ||
or not os.path.exists(mfa_config_path) | ||
): | ||
if not os.path.exists(mfa_dict_path) or not os.path.exists(mfa_model_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend modifying this to separately check if different files exist. Otherwise, it's unclear which specific file is missing.
if "librilight" in cfg.dataset: | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines of code imply that the LibriLight dataset does not undergo subsequent feature extraction; does it use online feature extraction? Can we add a condition here to determine whether the feature extraction method is online extraction or pre-extraction? This means our system will support two types of feature extraction methods.
P.S., we need to integrate the online feature extraction process later.
✨ Description
This PR aims to enhance the compatibility and efficiency of the librilight preprocessing scripts with the new NS2 framework to be updated by @HeCheng0625. By updating the librilight preprocessing scripts, we ensure they align with the new NS2 dataloader's expectations, facilitating smoother NS2 training processes. Besides, this PR also improves the usability of the original librilight preprocess scripts.
🚧 Related Issues
#115
👨💻 Changes Proposed
🧑🤝🧑 Who Can Review?
@HeCheng0625 @lmxue
🛠 TODO
✅ Checklist