Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Docker installation #140

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

yuantuo666
Copy link
Collaborator

@yuantuo666 yuantuo666 commented Feb 20, 2024

✨ Description

This PR adds a docker image for installation. It will be easier for beginners to configure the environment using Docker images.

🚧 Related Issues

#99

πŸ‘¨β€πŸ’» Changes Proposed

  • Add Dockerfile and corresponding installation guide
  • Modify env.sh for strict error report

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

@lmxue @RMSnow

πŸ›  TODO

  • Push image to Docker Hub
  • Test Docker image

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RMSnow RMSnow marked this pull request as ready for review February 22, 2024 05:59
@RMSnow RMSnow merged commit 1c4a9af into open-mmlab:main Feb 22, 2024
1 check passed
ArkhamImp pushed a commit to ArkhamImp/Amphion that referenced this pull request Apr 17, 2024
Provide dockerfile and docker installation instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants