Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless file #180

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Remove useless file #180

merged 1 commit into from
Apr 12, 2024

Conversation

Adorable-Qin
Copy link
Collaborator

@Adorable-Qin Adorable-Qin commented Apr 11, 2024

✨ Description

/modules/encoder/conv_encoder.py
This file is a deprecated file left over from the old implementation. It may cause unstable state as it contains invalid reference, so it is removed.

🚧 Related Issues

Issue 178

👨‍💻 Changes Proposed

  • Remove conv_encoder.py

🧑‍🤝‍🧑 Who Can Review?

@RMSnow

🛠 TODO

  • Nah.

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@Adorable-Qin Adorable-Qin requested a review from RMSnow April 11, 2024 12:48
@RMSnow RMSnow merged commit d335514 into open-mmlab:main Apr 12, 2024
1 check passed
ArkhamImp pushed a commit to ArkhamImp/Amphion that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants