Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for issue 76 (Import VariableSampler error) #78

Closed
wants to merge 3 commits into from
Closed

Fix bug for issue 76 (Import VariableSampler error) #78

wants to merge 3 commits into from

Conversation

HeCheng0625
Copy link
Collaborator

Fix bug for issue 76 (#76): ImportError: cannot import name 'VariableSampler' from 'models.base.base_sampler'. Replace VariableSampler from models.tts.valle.valle_dataset to models.base.base_sampler

Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is a commit "fix cosine_schedule_with_warmup", which has been done in #52. Did you create the PR from a new branch?

Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HeCheng0625 HeCheng0625 closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants