remove redundant codes and update the function for fs2 feature #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmxue
reviewed
Jan 2, 2024
| @@ -231,9 +231,6 @@ def extract_mel_features_tts( | |||
|
|
|||
| spec = torch.matmul(mel_basis[str(cfg.fmax) + "_" + str(y.device)], spec) | |||
| spec = spectral_normalize_torch(spec) | |||
| spec = spec.squeeze(0) | |||
There was a problem hiding this comment.
Are you sure it works to delete the code in line 234, which is not a repeated code?
There was a problem hiding this comment.
Yes, it's same as lines 165 to 168.
zhizhengwu
requested changes
Jan 2, 2024
lmxue
approved these changes
Jan 3, 2024
|
LGTM |
zhizhengwu
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redundant codes and update the function for fs2 feature