-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding warning for alpha flags #3764
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
@open-policy-agent/gatekeeper-maintainers There are other non-boolean alpha flags such as |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3764 +/- ##
==========================================
- Coverage 54.49% 47.70% -6.80%
==========================================
Files 134 236 +102
Lines 12329 19929 +7600
==========================================
+ Hits 6719 9507 +2788
- Misses 5116 9529 +4413
- Partials 494 893 +399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
what about all other alpha flags? https://github.com/search?q=repo%3Aopen-policy-agent%2Fgatekeeper%20%22(alpha)&type=code |
@ritazh Yeah those are non-boolean flags, so I am not sure when to log since non-boolean alpha flags are always in use. And if we add warnings for them now, it might alarm users and mislead them since some of these flags have been in alpha for very long time. |
emit-audit-events and enable-pub-sub are boolean flags and default to false. |
Warning for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3485
Special notes for your reviewer: