Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding annotation to generate VAPB right away once the waiting window is over to protect against clock skews #3773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3683

Special notes for your reviewer:

… is over to protect against clock skews

Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani JaydipGabani requested a review from a team as a code owner January 11, 2025 02:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 47.71%. Comparing base (3350319) to head (c566741).
Report is 227 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/constraint/constraint_controller.go 0.00% 13 Missing ⚠️
...onstrainttemplate/constrainttemplate_controller.go 94.73% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (c566741). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (c566741)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3773      +/-   ##
==========================================
- Coverage   54.49%   47.71%   -6.79%     
==========================================
  Files         134      236     +102     
  Lines       12329    19937    +7608     
==========================================
+ Hits         6719     9512    +2793     
- Misses       5116     9530    +4414     
- Partials      494      895     +401     
Flag Coverage Δ
unittests 47.71% <56.25%> (-6.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-clock-dependent annotation for VAPB generation
2 participants