Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gator test --deny-only flag #3809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WnP
Copy link
Contributor

@WnP WnP commented Feb 5, 2025

What this PR does / why we need it:

Add --deny-only flag to gator test command.

Which issue(s) this PR fixes:
Fixes #3808

@WnP WnP requested a review from a team as a code owner February 5, 2025 15:17
@WnP WnP force-pushed the gator-test-deny-only-flag branch 2 times, most recently from 8448062 to 7dfd213 Compare February 5, 2025 15:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.83%. Comparing base (3350319) to head (3304001).
Report is 249 commits behind head on master.

Files with missing lines Patch % Lines
cmd/gator/test/test.go 84.21% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (3304001). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (3304001)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3809      +/-   ##
==========================================
- Coverage   54.49%   47.83%   -6.67%     
==========================================
  Files         134      235     +101     
  Lines       12329    19876    +7547     
==========================================
+ Hits         6719     9507    +2788     
- Misses       5116     9479    +4363     
- Partials      494      890     +396     
Flag Coverage Δ
unittests 47.83% <84.21%> (-6.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steeve Chailloux <[email protected]>
@WnP WnP force-pushed the gator-test-deny-only-flag branch from 7dfd213 to 3304001 Compare February 5, 2025 15:54
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks for the pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gator test option to log only denied constraints
3 participants