Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Respect --v0-compatible for opa eval support modules #7251

Conversation

johanfylling
Copy link
Contributor

Fixing issue in the opa eval command where --v0-compatible was ignored for PE support modules when used in combination with the pretty output format; producing v1 support modules instead of v0.

Fixing: #7248

…dules

Fixing issue in the `opa eval` command where `--v0-compatible` was ignored for PE support modules when
used in combination with the `pretty` output format; producing v1 support modules instead of v0.

Fixing: open-policy-agent#7248
Signed-off-by: Johan Fylling <[email protected]>
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does this have any effect or relevance for optimized bundles? They can contain support module rego, too.

@johanfylling
Copy link
Contributor Author

Optimized bundles produced by opa build work as expected according my testing.

@johanfylling johanfylling merged commit 64ebe35 into open-policy-agent:main Jan 8, 2025
28 checks passed
@johanfylling johanfylling deleted the fix/eval_cmd_pe_v0-compatible branch January 8, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants