Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reaction from the scratch/import from the file #227

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

mnmsvlw
Copy link

@mnmsvlw mnmsvlw commented Jan 28, 2025

This PR includes:

  • CreateReactionMenu and CreateReactionFromFile components to support the creation and upload of reaction functionality
  • Corresponding store updates
  • Renaming of CreateDatasetLayout to FormModal to enable reuse for reactions


const result = await axiosInstance.post<ReactionResponse>(`/datasets/${datasetId}/reactions/upload`, formData);
const reaction = parseReaction(result.data);
return importReactionFromFileActions.success(reaction);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should redirect user to reaction page after import

@mnmsvlw mnmsvlw merged commit 86823f3 into develop Jan 29, 2025
6 checks passed
@mnmsvlw mnmsvlw deleted the feat/create_reaction branch January 29, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ORD-6.1.1] Create new Reaction. Import from a File [ORD-6.1] Create reaction from the scratch
2 participants