Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interface to use new schema enums in ord-schema PR #719 #113

Open
bdeadman opened this issue May 31, 2024 · 4 comments
Open

Update interface to use new schema enums in ord-schema PR #719 #113

bdeadman opened this issue May 31, 2024 · 4 comments
Assignees
@bdeadman
Labels
enhancement New feature or request

Comments

@bdeadman
Copy link
Collaborator

bdeadman commented May 31, 2024 •
edited
Loading

open-reaction-database/ord-schema#719 added some extra enum options which need to be enabled in the contributions interface.

addition device - pipette and positive displacement pipette
chemical identifier - MDL number
analysis type - CAD, optical rotation
@bdeadman
Copy link
Collaborator Author

bdeadman commented May 31, 2024 •
edited
Loading

link to issues open-reaction-database/ord-schema#607 and open-reaction-database/ord-schema#708

@bdeadman
Copy link
Collaborator Author

@skearnes @miori-nd

@bdeadman bdeadman assigned bdeadman and skearnes and unassigned bdeadman May 31, 2024
@bdeadman bdeadman added the enhancement New feature or request label May 31, 2024
@bdeadman bdeadman mentioned this issue Aug 5, 2024
Closed
@bdeadman
Copy link
Collaborator Author

@skearnes @miori-nd we have an ORD issues meeting on 27th. I'd like to use some of that time to go through the process of updating the interface to use the latest version of the schema, in the simple case where it is just some enums added to existing messages.

@bdeadman bdeadman assigned bdeadman and unassigned skearnes Dec 13, 2024
@bdeadman
Copy link
Collaborator Author

Process sorted out and I will:

  • document the process in the ord-schema README

@bdeadman bdeadman mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdeadman bdeadman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skearnes @bdeadman