Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optical rotation as an analysis type #607

Closed
brilee opened this issue Jul 14, 2021 · 1 comment
Closed

Add optical rotation as an analysis type #607

brilee opened this issue Jul 14, 2021 · 1 comment
Assignees
@bdeadman
Labels
enhancement New feature or request

Comments

@brilee
Copy link
Contributor

brilee commented Jul 14, 2021

The reaction_pb2.Analysis.AnalysisType enum doesn't have an entry for optical rotation. (It has one for circular dichroism which is related but not the same)
@brilee brilee added the enhancement New feature or request label Jul 14, 2021
@bdeadman bdeadman self-assigned this Apr 17, 2024
@bdeadman bdeadman mentioned this issue Apr 17, 2024
Closed
bdeadman added a commit that referenced this issue May 2, 2024
@bdeadman
Added some addition device types, and analysis types.
58f55dd 
Response to #607 and #708.
@bdeadman bdeadman mentioned this issue May 2, 2024
Closed
@FanwangM FanwangM mentioned this issue May 13, 2024
Merged
2 tasks
@bdeadman bdeadman mentioned this issue May 31, 2024
Open
@bdeadman
Copy link
Collaborator

bdeadman commented Aug 5, 2024 •
edited
Loading

Optical rotation in schema as of #719. Closing this issue as the change will be migrated to interface in #113.

@bdeadman bdeadman closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdeadman bdeadman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brilee @bdeadman