Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hard coded height #262

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: remove hard coded height #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cfdae3
remove hard coded height
bdougie May 1, 2024
386814c
Merge branch 'main' into fix-square-images
bdougie May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions components/sections/blog/components/Post.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,24 @@ import OrangeClock from '../../../../public/orange_clock.png'
import OrangeAuthor from '../../../../public/orange_author.png'
import { Button } from '../../../common'
import LocalTypography from './LocalTypography'
import { BiCalendarAlt } from "react-icons/bi";
import { BiCalendarAlt } from 'react-icons/bi'

interface PostProps {
data: Omit<SanityBlog, "author"> & { author: SanityAuthor }
data: Omit<SanityBlog, 'author'> & { author: SanityAuthor }
featured?: boolean
}

const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
const { title, topics, published_date, coverImage, author, summary, slug, blogContent } = data
const {
title,
topics,
published_date,
coverImage,
author,
summary,
slug,
blogContent,
} = data
const src = coverImage || ''
const href = `/blog/${slug?.current}`

Expand Down Expand Up @@ -46,8 +55,8 @@ const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
)}
<div className={`${featured && 'largeTablet:hidden'}`}>
<GradientBorderWrapper style={{ width: '100%', borderRadius: '5px' }}>
<div className="w-full h-[304px] relative rounded-[5px] overflow-hidden ">
<Image width="580" height={304} src={src as string} alt="Cover"/>
<div className="w-full relative rounded-[5px] overflow-hidden ">
<Image width="580" height={304} src={src as string} alt="Cover" />
</div>
</GradientBorderWrapper>
</div>
Expand All @@ -61,7 +70,10 @@ const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
</div>
<div className=" min-h-[55px] largeTablet:min-h-[90px]">
<LocalTypography featured={featured} variant="title">
<a href={href} className="hover:text-brandOrange hover:decoration-brandOrange transition-all">
<a
href={href}
className="hover:text-brandOrange hover:decoration-brandOrange transition-all"
>
{title}
</a>
</LocalTypography>
Expand All @@ -75,22 +87,24 @@ const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
<div className="flex-shrink-0 mr-2 ml-4">
<Image src={OrangeClock} alt="Time" />
</div>
<LocalTypography>{`${getReadTime(blogContent || "")} ${
getReadTime(blogContent || "") === 1 ? 'min' : 'mins'
<LocalTypography>{`${getReadTime(blogContent || '')} ${
getReadTime(blogContent || '') === 1 ? 'min' : 'mins'
} read`}</LocalTypography>

{ published_date && (
{published_date && (
<>
<div className="flex-shrink-0 mr-2 ml-4">
<BiCalendarAlt className='text-[#E33E24] w-5 h-5' />
<BiCalendarAlt className="text-[#E33E24] w-5 h-5" />
</div>
<LocalTypography>
<time>{published_date}</time>
</LocalTypography>
</>
)}
</div>
<Typography variant="body1" alignLarge='left'>{getDisplaySummary()}</Typography>
<Typography variant="body1" alignLarge="left">
{getDisplaySummary()}
</Typography>
<div className="pt-10">
<Button href={href}>Read More</Button>
</div>
Expand Down
Loading