remove some array and list allocations (#6133)

open-telemetry · Feb 13, 2025 · 62af9ad · 62af9ad
1 parent 3c62f6b
commit 62af9ad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/OpenTelemetry/Metrics/View/ExplicitBucketHistogramConfiguration.cs b/src/OpenTelemetry/Metrics/View/ExplicitBucketHistogramConfiguration.cs
@@ -25,7 +25,7 @@ public class ExplicitBucketHistogramConfiguration : HistogramConfiguration
     /// </remarks>
     public double[]? Boundaries
     {
-        get => this.CopiedBoundaries != null ? this.CopiedBoundaries.AsSpan().ToArray() : null;
+        get => this.CopiedBoundaries?.ToArray();
 
         set
         {
@@ -36,7 +36,7 @@ public double[]? Boundaries
                     throw new ArgumentException($"Histogram boundaries are invalid. Histogram boundaries must be in ascending order with distinct values.", nameof(value));
                 }
 
-                this.CopiedBoundaries = value.AsSpan().ToArray();
+                this.CopiedBoundaries = value.ToArray();
             }
             else
             {

diff --git a/src/OpenTelemetry/Metrics/View/MetricStreamConfiguration.cs b/src/OpenTelemetry/Metrics/View/MetricStreamConfiguration.cs
@@ -71,8 +71,8 @@ public string? Name
     /// </remarks>
     public string[]? TagKeys
     {
-        get => this.CopiedTagKeys != null ? this.CopiedTagKeys.AsSpan().ToArray() : null;
-        set => this.CopiedTagKeys = value != null ? value.AsSpan().ToArray() : null;
+        get => this.CopiedTagKeys?.ToArray();
+        set => this.CopiedTagKeys = value?.ToArray();
     }
 
     /// <summary>

diff --git a/src/Shared/Options/DelegatingOptionsFactory.cs b/src/Shared/Options/DelegatingOptionsFactory.cs
@@ -64,9 +64,9 @@ public DelegatingOptionsFactory(
 
         this.optionsFactoryFunc = optionsFactoryFunc!;
         this.configuration = configuration!;
-        _setups = setups as IConfigureOptions<TOptions>[] ?? new List<IConfigureOptions<TOptions>>(setups).ToArray();
-        _postConfigures = postConfigures as IPostConfigureOptions<TOptions>[] ?? new List<IPostConfigureOptions<TOptions>>(postConfigures).ToArray();
-        _validations = validations as IValidateOptions<TOptions>[] ?? new List<IValidateOptions<TOptions>>(validations).ToArray();
+        _setups = setups as IConfigureOptions<TOptions>[] ?? setups.ToArray();
+        _postConfigures = postConfigures as IPostConfigureOptions<TOptions>[] ?? postConfigures.ToArray();
+        _validations = validations as IValidateOptions<TOptions>[] ?? validations.ToArray();
     }
 
     /// <summary>