-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support output value in AttributeSetter #6543
Support output value in AttributeSetter #6543
Conversation
ae8c6cb
to
a976877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a changelog entry.
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
=====================================
Coverage 73.0% 73.0%
=====================================
Files 189 189
Lines 15754 15773 +19
=====================================
+ Hits 11503 11519 +16
- Misses 3916 3920 +4
+ Partials 335 334 -1
|
a976877
to
e8d0895
Compare
…with output value. Thanks to that, users can instrument attributes based on the AWS SDK responses.
e8d0895
to
6e05dfc
Compare
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
Co-authored-by: Damien Mathieu <[email protected]>
@dmathieu @akats7 I will never merge that PR. Every time I resolve conflicts, checks are blocked and have to be approved, and after they are approved, there is a new merge to the main, and again, I can't merge it because of a conflict. Could you help me? Could you merge it after the checks pass? I am not getting any notifications after your approval; the checks are green. |
# Conflicts: # CHANGELOG.md
Ping @open-telemetry/go-approvers for second review. |
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes_test.go
Outdated
Show resolved
Hide resolved
8a9ab09
to
cb3594a
Compare
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync with main
and address the comment.
I plan to approve and merge this on Friday given all comments are addressed.
…ed to project style
cb3594a
to
d37aea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Planning to merge this on Friday.
@SodaDev, thank you for your contribution 🏅
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
@dmathieu, can you make a double-check and merge? |
@SodaDev, thank you for your contribution 🏅 |
Reasoning:
Add AttributeBuilder, which will extend the AttributeSetter contract with output value. Thanks to that, users can instrument attributes based on the AWS SDK responses.