Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count code owners approvals towards the two required approvals #6675

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Count code owners approvals towards the two required approvals #6675

merged 1 commit into from
Jan 23, 2025

Conversation

dmathieu
Copy link
Member

As we discussed during the SIG meeting, this allows counting code owners approvals for mergeability of a PR.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 23, 2025
@dmathieu dmathieu marked this pull request as ready for review January 23, 2025 17:52
@dmathieu dmathieu requested a review from a team as a code owner January 23, 2025 17:52
@pellared pellared merged commit e6b3142 into open-telemetry:main Jan 23, 2025
28 checks passed
@dmathieu dmathieu deleted the allow-code-owners-approvals branch January 23, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmathieu @dashpole @pellared @MrAlias @XSAM