-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: experimental Trace SDK self-observability metrics #6153
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
=======================================
- Coverage 82.2% 82.2% -0.1%
=======================================
Files 273 274 +1
Lines 23744 23923 +179
=======================================
+ Hits 19539 19672 +133
- Misses 3856 3891 +35
- Partials 349 360 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start, I like the approach. 👍
Turns out there are already proposed semantic conventions: open-telemetry/semantic-conventions#1631 |
18534c3
to
dda5658
Compare
I updated this to match the proposed conventions. |
…n_processor.queue_size metric
dda5658
to
21e5323
Compare
…ocessor.spans_processed self-observability metrics
21e5323
to
f508b24
Compare
95ddc6f
to
5d6f316
Compare
This now implements all of the proposed conventions (although those may still change). I didn't implement it (yet) for the OTLP http proto or json exporters or for the simple span processor. |
Part of #2547
This adds the
OTEL_GO_X_SELF_OBSERVABILITY
feature gate, theotel.sdk.span.processor.queue_size
metric behind it.Note: I opted for a single environment variable for all SDKs and for all signals, rather than multiple environment variables.
TODO: