fix(operator): feature gates map allows add empty items #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+164
to
+165
| {{- if $v -}} | ||
| {{- $list = append $list (printf "%s=true" $k) -}} |
There was a problem hiding this comment.
If someone explicitly set asdsadsa.adsads2: false we should disable that feature gate. Let's add an else case to set -asdsadsa.adsads2
Comment on lines
+164
to
+165
| {{- if $v -}} | ||
| {{- $list = append $list (printf "%s=true" $k) -}} |
There was a problem hiding this comment.
Feature gates are not enabled with =true. If the value is true the key should be added to the list, but nothing additional is needed.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a feature flag with the value defined as
false, the rendered string will contain a empty comma and this triggers a failure in the operator.An example in the Helm playground.