Fix HBase test flakiness #1615
Merged
Fix HBase test flakiness #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
approved these changes
Dec 18, 2024
| @@ -125,45 +123,6 @@ void endToEndTest(@TempDir Path tmpDir) { | |||
| verifyMetrics(); | |||
| } | |||
|
|
|||
| // TODO: This implementation is DEPRECATED and will be removed once all integration tests are | |||
| // migrated to MetricsVerifier | |||
| protected void waitAndAssertMetrics(Iterable<Consumer<Metric>> assertions) { | |||
There was a problem hiding this comment.
[for reviewer] this is not related to this PR, but is not used anymore.
laurit
approved these changes
Dec 18, 2024
breedx-splk
reviewed
Dec 18, 2024
| "data point attributes '%s' for metric '%s' must match exactly one of the attribute sets '%s'", | ||
| dataPointAttributes, actual.getName(), Arrays.asList(matcherGroups)); | ||
| "data point attributes '%s' for metric '%s' must match exactly one of the attribute sets '%s'.\nActual data points: %s", | ||
| dataPointAttributes, actual.getName(), Arrays.asList(matcherGroups), dataPoints); |
There was a problem hiding this comment.
The toString() probably leaves a little be desired, but is workable.
breedx-splk
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Part of fix for #1605
HBase is doing a lot of things after all the ports are open and before it completes its initialization. Because of this the test may be flaky.
Scope