-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate b3 parentspanid and debug flag #1346
Propagate b3 parentspanid and debug flag #1346
Conversation
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 149 147 -2
Lines 4272 4190 -82
Branches 871 860 -11
==========================================
- Hits 4000 3923 -77
+ Misses 272 267 -5
|
Unrelated, but the test 'should gracefully handle an invalid b3 header' doesn't seem to be testing what we want. |
0492264
to
bfaa63c
Compare
30a8b86
to
df4cb29
Compare
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
c8add74
to
cdbd1cb
Compare
cdbd1cb
to
1a13d1d
Compare
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
cc5ede0
to
bfd2885
Compare
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a situation when those 2 values will be set together ?
assert.strictEqual(context.getValue(DEBUG_FLAG_KEY), '1');
assert.equal(context.getValue(PARENT_SPAN_ID_KEY), 'Something else the undefined');
1a52ab7
to
3adff4f
Compare
12755a7
to
dcca659
Compare
dcca659
to
0e2b8d0
Compare
0e2b8d0
to
849f915
Compare
Yeah, added a test for both of them being set |
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
Forgot to add the reason I set my review status to "requested changes" is due to the undefined use of the traceflags second bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for changes - the code is easier to read :).
If possible I would like to encourage you yet to rewrite description of unit test a bit. So they are more readable and are written in style of "when -> then". It also helps to document the code and to understand it faster whenever someone will try to fix the problem in future when tests are failing or need to refactor code. I have added 2 examples what I have on my mind, thank you
bdecf88
to
55304c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for changes
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one small comment - going to provide LGTM and hope you can address prior to merging.
done, thanks |
* feat: graceful shutdown for tracing and metrics * fix: wording in test case * fix: typo * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <[email protected]> * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <[email protected]> * fix: add callbacks to shutdown methods * fix: merge conflict * simplify meter shutdown code Co-authored-by: Daniel Dyla <[email protected]> * fix: fix one-liner * private function name style fix Co-authored-by: Daniel Dyla <[email protected]> * fix: naming of private member variables * fix: graceful shutdown now works in browser * fix: window event listener will trigger once * fix: modify global shutdown helper functions * fix: remove callback from remove listener args * fix: change global shutdown function names and simplify functionality * fix: add rest of function refactoring and simplification * fix: remove unintended code snippet * fix: refactor naming of listener cleanup function and fix sandbox issue * fix: make global shutdown cleanup local * fix: change interval of MeterProvider collection to ensure it does not trigger through clock * chore: removing _cleanupGlobalShutdownListeners * fix: remove unnecesary trace provider member function * Removing default span attributes (#1342) * refactor(opentelemetry-tracing): removing default span attributes Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing default span attributed from tracer object Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing accidental add to package.json Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <[email protected]> * feat: add baggage support to the opentracing shim (#918) Co-authored-by: Mayur Kale <[email protected]> * Add nodejs sdk package (#1187) Co-authored-by: Naseem <[email protected]> Co-authored-by: legendecas <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Matthew Wear <[email protected]> * feat: add OTEL_LOG_LEVEL env var (#974) * Proto update to latest to support arrays and maps (#1339) * chore: 0.10.0 release proposal (#1345) * fix: add missing grpc-js index (#1358) * chore: 0.10.1 release proposal (#1359) * feat(api/context-base): change compile target to es5 (#1368) * Feat: Make ID generator configurable (#1331) Co-authored-by: Daniel Dyla <[email protected]> * fix: require grpc-js instead of grpc in grpc-js example (#1364) Co-authored-by: Bartlomiej Obecny <[email protected]> * chore(deps): update all non-major dependencies (#1371) * chore: bump metapackage dependencies (#1383) * chore: 0.10.2 proposal (#1382) * fix: remove unnecesary trace provider member function * refactor(metrics): distinguish different aggregator types (#1325) Co-authored-by: Daniel Dyla <[email protected]> * Propagate b3 parentspanid and debug flag (#1346) * feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320) Co-authored-by: Daniel Dyla <[email protected]> * feat: Collector Metric Exporter for the Web (#1308) Co-authored-by: Daniel Dyla <[email protected]> * Fix issues in TypeScript getting started example code (#1374) Co-authored-by: Daniel Dyla <[email protected]> * chore: deploy canary releases (#1384) * fix: protos pull * fix: address marius' feedback * chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier * fix: add documentation and cleanup code * fix: remove async label from shutdown and cleanup test case * fix: update controller collect to return promise * fix: make downsides of disabling graceful shutdown more apparent Co-authored-by: Daniel Dyla <[email protected]> Co-authored-by: Bartlomiej Obecny <[email protected]> Co-authored-by: Aravin <[email protected]> Co-authored-by: Ruben Vargas Palma <[email protected]> Co-authored-by: Mayur Kale <[email protected]> Co-authored-by: Naseem <[email protected]> Co-authored-by: legendecas <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Naseem <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Cong Zou <[email protected]> Co-authored-by: Reginald McDonald <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: srjames90 <[email protected]> Co-authored-by: David W <[email protected]> Co-authored-by: Mick Dekkers <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Which problem is this PR solving?
Short description of the changes