Yii2 framework instrumentation #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
============================================
- Coverage 33.10% 32.02% -1.09%
- Complexity 853 878 +25
============================================
Files 76 79 +3
Lines 3250 3360 +110
============================================
Hits 1076 1076
- Misses 2174 2284 +110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
brettmc
requested changes
Nov 20, 2023
brettmc
approved these changes
Nov 21, 2023
|
one psalm issue to fix (ignore) and then I'm happy to merge and publish this. |
|
As @brettmc mentioned, psalm issue, but overall LGTM |
pdelewski
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Yii 2.0.13+ auto-instrumentation (open-telemetry/opentelemetry-auto-yii package). Earlier versions have a class naming conflict with PHP 8.0+ itself. Currently only collects root span.