feat: [es] Create docs/languages/js/_index.md #5327
Conversation
opentelemetrybot
requested review from
a team and
krol3
and removed request for
a team
|
+CC @krol3 |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11659573015 |
|
IMPORTANT: (RE-)RUN
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
default_lang_commit value was fixed |
There was a problem hiding this comment.
Let me investigate if we can achieve the same result without introducing an extra parameter.
|
This PR needs to be rebased. /cc @theletterf |
| @@ -3,25 +3,26 @@ | |||
| <!-- prettier-ignore --> | |||
| ` -}} | |||
| {{ $lang := .Get 0 -}} | |||
| {{ $translation := .Get 1 -}} | |||
There was a problem hiding this comment.
Please accept the following change, and then revert all of the "en" argument additions to the en pages:
| {{ $translation := .Get 1 -}} | |
| {{ $translation := .Get 1 | default "en" -}} |
chalin
force-pushed
the
docs/languages/index
branch
from
b049432 to
d33fc6d
Compare
I've rebased and resolved conflicts as best I could. PTAL |
|
@theletterf et all: in general, please tag me on localization PRs that have such a "broad" (cross-localization) impact and/or changes to shared layouts so that we can together assess and discuss design alternatives. Hugo has built-in support for i18n, in the way that you've implemented it here. So we don't need to re-implement our own localization tag support. I need to think about this a bit more before I can make some concrete suggestions. Stay tuned! |
There was a problem hiding this comment.
After thinking about this more, for the moment, I'd rather that each locale create it's own version of the shortcode, like this: layouts/shortcodes/pt/docs/languages/index-intro.md.
There are pros and cons to this approach, vs. the i18n-tag approach you've suggested here (which, if we were to adopt, I'd suggest rewriting so that we use Hugo's native support). For now, I'm voting for the per-locale shortcode approach, but I'm open to discussing this more with @open-telemetry/docs-es-approvers if they feel strongly about the alternative.
@open-telemetry/docs-approvers - please also share your opinion.
Signed-off-by: Oscar Ayra <[email protected]>
Signed-off-by: Oscar Ayra <[email protected]>
Signed-off-by: Oscar Ayra <[email protected]>
Signed-off-by: Oscar Ayra <[email protected]>
Signed-off-by: Oscar Ayra <[email protected]>
chalin
force-pushed
the
docs/languages/index
branch
from
d33fc6d to
81b73a8
Compare
|
|
||
| The current status of the major functional components for OpenTelemetry | ||
| {{ $name }} is as follows: | ||
| {{ $traces := $content.introPage.releases.traces }} |
There was a problem hiding this comment.
| {{ $traces := $content.introPage.releases.traces }} | |
| {{ $traces := $content.introPage.releases.traces }} |
@oayras gracias por tu contribucion, seria un abordage mas simples, traduzir el texto, sin necesitad de agregar nuevos archivos en data/languages/en.yaml. Por favor intentar este abordage, y podemos hacer un zoom. Por favor escribeme en el slack
Related issue #5229