Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix fix:dict and run it #6143

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 31, 2025

  • Fixes [CI] fix:dict fails to run in GH jobs #6142
    • For some reason the shell used by NPM was a barebones one, not bash. Anyhow, fixed this by avoiding path expansion using the {...} syntax.
  • Runs fix:dict on all locales now
  • Includes the results of running fix:dict

@chalin chalin added the CI/infra CI & infrastructure label Jan 31, 2025
@chalin chalin requested a review from a team as a code owner January 31, 2025 12:17
@chalin chalin marked this pull request as draft January 31, 2025 12:17
@opentelemetrybot opentelemetrybot requested review from a team January 31, 2025 12:17
@chalin chalin changed the title [CI] Run fix:dict [CI] Fix fix:dict and run it Jan 31, 2025
@chalin chalin force-pushed the chalin-fix-dict-2025-01-31 branch 2 times, most recently from 35c7eaf to 45dc931 Compare January 31, 2025 12:35
@chalin chalin marked this pull request as ready for review January 31, 2025 12:35
@opentelemetrybot opentelemetrybot requested review from a team January 31, 2025 12:35
@chalin chalin force-pushed the chalin-fix-dict-2025-01-31 branch from 45dc931 to cd2b322 Compare January 31, 2025 12:38
@chalin chalin force-pushed the chalin-fix-dict-2025-01-31 branch from cd2b322 to a4493d9 Compare January 31, 2025 12:54
@@ -65,7 +65,7 @@
"diff:check": "npm run _diff:check || (echo; echo 'WARNING: the files above have not been committed'; echo)",
"diff:fail": "npm run _diff:check || (echo; echo 'ERROR: the files above have changed. Locally rerun `npm run test-and-fix` and commit changes'; echo; exit 1)",
"fix:all": "npm run all -- $(npm -s run _list:fix:*)",
"fix:dict": "find content/{en,es,fr,pt} layouts -name \"*.md\" -print0 | xargs -0 scripts/normalize-cspell-front-matter.pl",
"fix:dict": "find content layouts -name \"*.md\" -print0 | xargs -0 scripts/normalize-cspell-front-matter.pl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix page-local dict in all locales.

@chalin chalin merged commit 0d38602 into open-telemetry:main Jan 31, 2025
17 checks passed
@chalin chalin deleted the chalin-fix-dict-2025-01-31 branch January 31, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[CI] fix:dict fails to run in GH jobs
2 participants