Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcs] add vcs.change.time_to_merge metric #1685

Merged
merged 19 commits into from
Jan 23, 2025
Merged

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Dec 14, 2024

Changes

Adds the vcs.change.time_to_merge metric from the GitHub Receiver. It didn't make as part of a previous pull request.

Merge requirement checklist

@adrielp adrielp requested review from a team as code owners December 14, 2024 23:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vcs.change.time_to_merge metric was removed in the previous PR following this discussion: #1383 (comment)
I thought that vcs.change.state attribute on the vcs.change.duration metric was sufficient to distinguish them, but it makes sense to have time_to_merge separate.

model/vcs/metrics.yaml Outdated Show resolved Hide resolved
model/vcs/metrics.yaml Show resolved Hide resolved
Copy link

github-actions bot commented Jan 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 3, 2025
docs/cicd/cicd-metrics.md Show resolved Hide resolved
model/vcs/metrics.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jan 7, 2025
@christophe-kamphaus-jemmic
Copy link
Contributor

Let's add the vcs.change.time_to_merge metric in the markdown. cf #1685 (comment)

model/vcs/metrics.yaml Show resolved Hide resolved
model/vcs/metrics.yaml Outdated Show resolved Hide resolved
docs/cicd/cicd-metrics.md Outdated Show resolved Hide resolved
docs/cicd/cicd-metrics.md Outdated Show resolved Hide resolved
@adrielp adrielp requested a review from lmolkova January 22, 2025 16:23
@adrielp
Copy link
Contributor Author

adrielp commented Jan 22, 2025

Markdown link check continues to fail. Those URL's are good though. Seems to be flaky and unrelated to my changes.

@adrielp adrielp added this to the v1.30.0 milestone Jan 23, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
@lmolkova lmolkova merged commit 7bde041 into open-telemetry:main Jan 23, 2025
15 checks passed
@adrielp adrielp deleted the vcs-ttm branch January 24, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants