Less release steps #1793
Open
Less release steps #1793
+87
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Jan 23, 2025
There was a problem hiding this comment.
this file needed to be outside of the workflows directory in order for the automation to be able to update it, so I went ahead and moved all of the scripts to the same place
joaopgrassi
reviewed
Jan 23, 2025
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| current_version=$(grep "PREVIOUS_SPECIFICATION_VERSION=v.*" \ |
There was a problem hiding this comment.
Should this be getting the value ofLATEST_SPECIFICATION_VERSION and replacing it on PREVIOUS_SPECIFICATION_VERSION as the guide said?
There was a problem hiding this comment.
I'm not sure I totally follow, I think I removed the need for that step by only maintaining a single version in the file (which aligns with the version currently used in the links)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically sends a PR to update spec repo links whenever there is a spec release.
Example PR: trask#7