Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot stable2412 #1018

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Polkadot stable2412 #1018

merged 5 commits into from
Jan 30, 2025

Conversation

xlc
Copy link
Member

@xlc xlc commented Jan 29, 2025

No description provided.

@xlc xlc mentioned this pull request Jan 29, 2025
@vklachkov
Copy link
Contributor

Found workaround for build:

cargo update [email protected] --precise 3.6.12
cargo update [email protected] --precise 3.6.12

@vklachkov

This comment was marked as outdated.

@vklachkov
Copy link
Contributor

I pushed my fixes here. All tests are green. @xlc can you cherrypick this commit into PR please?

@vklachkov
Copy link
Contributor

@xlc thanks for cherrypick and hot fix! Can you add workaround to CI and Makefile?

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.37%. Comparing base (59e3734) to head (5b27d65).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
asset-registry/src/impls.rs 0.00% 3 Missing ⚠️
benchmarking/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   65.40%   65.37%   -0.03%     
==========================================
  Files          49       49              
  Lines        3726     3726              
==========================================
- Hits         2437     2436       -1     
- Misses       1289     1290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlc xlc marked this pull request as ready for review January 30, 2025 00:56
@xlc xlc merged commit ee451b0 into master Jan 30, 2025
5 of 7 checks passed
@xlc xlc deleted the polkadot-stable2412 branch January 30, 2025 00:57
@xlc xlc restored the polkadot-stable2412 branch January 30, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants