Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#478 systemd watchdog #543

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Feature/#478 systemd watchdog #543

merged 2 commits into from
Jan 26, 2024

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Jan 26, 2024

Implements "Issue" 0 of #541 (comment)

@mpass99 mpass99 requested a review from MrSerth January 26, 2024 21:41
@mpass99 mpass99 self-assigned this Jan 26, 2024
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you (and great that you made two commits, one for reverting the previous one and a dedicated new one introducing the new debug statement).

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (213628b) 75.84% compared to head (f59a5eb) 75.85%.

Files Patch % Lines
pkg/logging/logging.go 72.72% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   75.84%   75.85%           
=======================================
  Files          39       39           
  Lines        3975     3976    +1     
=======================================
+ Hits         3015     3016    +1     
  Misses        761      761           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth MrSerth merged commit ae86b1c into main Jan 26, 2024
11 of 12 checks passed
@MrSerth MrSerth deleted the feature/#478-systemd-watchdog branch January 26, 2024 21:51
@MrSerth
Copy link
Member

MrSerth commented Jan 26, 2024

I already deployed the most recent version of Poseidon and configured the TRACE logging once again. Now, we can wait for the next occurrence of this issue to gain further clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants