DRY up selectize users helpers #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bear454
force-pushed
the
selectize-user-helpers
branch
from
bb29162 to
d655247
Compare
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
+ Coverage 83.86% 83.87% +<.01%
==========================================
Files 141 141
Lines 4698 4700 +2
==========================================
+ Hits 3940 3942 +2
Misses 758 758
Continue to review full report at Codecov.
|
|
This may make #2008 easier to resolve ;-) |
Ana06
reviewed
Jun 15, 2018
app/views/booths/_form.html.haml
Outdated
| @@ -24,7 +24,6 @@ | |||
| :javascript | |||
| $(document).ready(function() { | |||
| $('#booth_responsible_ids').selectize({ | |||
| plugins: ['remove_button'], | |||
| minItems: 2 | |||
There was a problem hiding this comment.
Nice catch, thanks!
app/helpers/application_helper.rb
Outdated
| form.input :speakers, as: :select, | ||
| collection: options_for_select(users.map {|user| ["#{user[1]} (#{user[2]}) #{user[3]}", user[0]]}, @event.speakers.map(&:id)), | ||
| include_blank: false, label: 'Speakers', input_html: { class: 'select-help-toggle', multiple: 'true' } | ||
| # users = User.active.pluck(:id, :name, :username, :email).map { |user| [user[0], user[1].blank? ? user[2] : user[1], user[2], user[3]] }.sort_by { |user| user[1].downcase } |
There was a problem hiding this comment.
shouldn't those comments be removed as well? 😕
There was a problem hiding this comment.
Yes... sorry I forgot to remove those.
(cherry picked from commit eb38ddc)
bear454
force-pushed
the
selectize-user-helpers
branch
from
d655247 to
d286191
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit eb38ddc)
Checklist
masterbranch.Short description of what this resolves/which issues does this fix?:
selectize...helpers had duplicate code.Changes proposed in this pull request:
selectize...helpers.