Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracked devices detection #176

Closed
wants to merge 1 commit into from

Conversation

TobiPeterG
Copy link
Collaborator

@TobiPeterG TobiPeterG commented Dec 20, 2024

Fixes #160 for me, please check if detecting tracked devices still works for you :)
(Also adding a bit of logging)

@TobiPeterG
Copy link
Collaborator Author

The issue is that my crypttab sometimes contains spaces and sometimes tabs and the original pattern wasn't happy with that ;)

Copy link
Collaborator

@aplanas aplanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to change it to grep -E -q "$dev[[:space:]].*x-sdbootutil.ignore" /etc/crypttab && continue?

@aplanas
Copy link
Collaborator

aplanas commented Jan 10, 2025

Alternative: #188

aplanas added a commit to aplanas/sdbootutil that referenced this pull request Jan 10, 2025
@TobiPeterG
Copy link
Collaborator Author

Closed in favor of #188

@TobiPeterG TobiPeterG closed this Jan 10, 2025
aplanas added a commit to aplanas/sdbootutil that referenced this pull request Jan 10, 2025
aplanas added a commit that referenced this pull request Jan 10, 2025
aplanas added a commit to aplanas/sdbootutil that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] x-sdbootutil.ignore not always working
2 participants