-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Feat: add autoremove #578
base: master
Are you sure you want to change the base?
Conversation
45b6150
to
fc190a3
Compare
Co-authored-by: janvhs <[email protected]>
fc190a3
to
ce5597d
Compare
It looks like RCF in the title meant RFC? If you don't want it to be merged yet, you should mark it as draft, which prevents that. Otherwise just remove RFC from title and description, in case maintainers don't require changes and would like to merge it. |
ah thanks I didn't realize that I typoed RFC, I'll move it to a draft for now, I believe it should be fine to just merge it, in the current state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate this Hackweek project!
Some minor nits pointed out inline.
In fact a The kind of downside of your approach is that it is zypper only and that it's not under direct control of the resolver. I.e. you pass explicit remove requests for packages based on a previous computation rather than asking the resolver itself to compute the job. Implemented in libzypp, the job will become available to YAST and PK as well. |
This is a request for comment on a zypper autoremove command. As a system in updated during its life cycle packages can get left behind. While zypper has
rm --cleap-deps
anddup --remove-orphaned
both have short comings. rm only handles the package passed to it and removing orphans can remove packages a user explicitly built and installed themselves.To bring zypper inline with the wider linux package manager system(dnf, apt/apt-get) I added a zypper autoremove command. This is code does require reworking of some parts but as it stands this will clean up unneeded and orphaned packages based on flags passed.
Thanks @janvhs who helped debug some issues with the code