Eject project from expo #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e app still ran on iOS and Android devices. Also made changes to README to update instructions for running the project.
jmiranda
approved these changes
Jun 29, 2021
|
This works fine, let's merge it. |
|
Thanks Vishan will merge today
…On Tue, Jul 20, 2021 at 12:40 AM Vishan Seru ***@***.***> wrote:
This works fine, let's merge it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI35N6GNYPJF2LKYLVEKYTTYUD5LANCNFSM47QM3U6A>
.
|
jmiranda
changed the title
jmiranda
changed the title
|
I moved OBKN-44 to its own branch / PR #11 and merged it to develop. Then I reverted the last commit (OBKN-44) and force pushed the code to the remote expo_eject branch. I'm going to leave this branch alone until I can resolve #10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning has been explained in this comment.