BigQuery TAP support #172
Open
BigQuery TAP support #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add this to the Below cadc-tap-server-oracle (which I just fixed so you will need to pull main) and in that same style. We haven't got to it yet in tap.git (technical debt), but in many repos we also run the |
|
Hi @pdowler - is there anything else needed on this PR? I believe the build steps were addressed. |
|
I started reviewing the details but got side tracked. The ball is in my
court now.
…--
Patrick Dowler
Canadian Astronomy Data Centre
Victoria, BC, Canada
On Thu, 6 Feb 2025 at 06:09, dspeck1 ***@***.***> wrote:
Hi @pdowler <https://github.com/pdowler> - is there anything else needed
on this PR? I believe the build steps were addressed.
—
Reply to this email directly, view it on GitHub
<#172 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADIEM7U4DPJHGOVY72DRWED2ONULHAVCNFSM6AAAAABNXAPIMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZZHEZTIMJWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tap support for BigQuery. Includes the geometric conversions from TAP to BigQuery geometric functions. The TAP server example for running this will be provided in a different repository.