-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Parquet as Response Format. #181
base: main
Are you sure you want to change the base?
Conversation
Integrated ParquetWriter to youcat service.
For the ParquetWriterRoundtripTest: if you extended the AbstractTablesTest, you could write a complete lifecycle test pretty easily using utility methods in the base class. See CreateTableTest and LoadTableTest for examples.
|
Parquet Round trip tests changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mostly looks good - just one detail noted in test code.
I haven't reviewed the ParquetWriter test class - I think I'll wait until I can can pull the changes in and run it in my dev environment before looking at those details.
@@ -352,6 +352,7 @@ protected void setPerms(Subject subject, String name, TapPermissions tp, int exp | |||
HttpPost post = new HttpPost(schemaURL, content, false); | |||
post.setMaxRetries(0); // testing read-only and offline mode | |||
Subject.doAs(subject, new RunnableAction(post)); | |||
System.out.println(post.getThrowable().getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first, we never use System.out... always log.{level}
The Throwable here may be null so this could cause a NullPointerException
I often like to see raw response info logged before any assert(s) are done and this is a common and useful statement
log.info("post: " + post.getResponseCode() + " " + post.getThrowable());
which is safe and informative when calling REST APIs.
No description provided.