Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Diagnosis example #16

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Add Diagnosis example #16

merged 10 commits into from
Oct 11, 2024

Conversation

njordr
Copy link
Collaborator

@njordr njordr commented Oct 11, 2024

  • add example on how to use diagnosis

@njordr njordr requested a review from mimir-d October 11, 2024 08:47
mimir-d
mimir-d approved these changes Oct 11, 2024
View reviewed changes
examples/diagnosis.rs
let fan_speed = get_fan_speed();

if fan_speed >= 1600 {
step.diagnosis("fan_ok", tv::DiagnosisType::Pass).await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to encourage the usage of the macros with source location?

njordr added 3 commits October 11, 2024 11:29
@njordr
Fix comments in PR
0851684 
Signed-off-by: Giovanni Colapinto <[email protected]>
@njordr
Add Diagnosis example
e14bedf 
Signed-off-by: Giovanni Colapinto <[email protected]>
@njordr
Add example with macros
88ada06 
Signed-off-by: Giovanni Colapinto <[email protected]>
@njordr njordr force-pushed the fea/diagnosis_example branch from 99c8325 to 88ada06 Compare October 11, 2024 11:46
mimir-d
mimir-d approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@mimir-d mimir-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

njordr and others added 4 commits October 11, 2024 13:59
@njordr
Merge pull request #15 from opencomputeproject/fea/file_object
ed468d9 
Add File module
@njordr
Add Diagnosis example
933aee0 
Signed-off-by: Giovanni Colapinto <[email protected]>
@njordr
Add example with macros
12931fe 
Signed-off-by: Giovanni Colapinto <[email protected]>
@njordr
Rebase
88035fa 
Signed-off-by: Giovanni Colapinto <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.5%. Comparing base (1e5b0a9) to head (88035fa).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
src/output/step.rs 87.5% 2 Missing ⚠️
Additional details and impacted files

@njordr njordr merged commit 81fc064 into dev Oct 11, 2024
12 of 13 checks passed
@njordr njordr deleted the fea/diagnosis_example branch October 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimir-d mimir-d mimir-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njordr @mimir-d