Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rfc8572 DHCP option encoding. #128

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

gmacf
Copy link
Contributor

@gmacf gmacf commented Feb 27, 2024

Closes #116

@gmacf gmacf linked an issue Feb 27, 2024 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8063303825

Details

  • -34 of 34 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 27.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dhcp/main/dhcp.go 0 1 0.0%
dhcp/dhcp.go 0 3 0.0%
dhcp/plugins/bootz/bootz.go 0 30 0.0%
Totals Coverage Status
Change from base Build 7906564035: -0.3%
Covered Lines: 683
Relevant Lines: 2458

💛 - Coveralls

@gmacf gmacf requested a review from sam-homa February 28, 2024 00:10
@gmacf
Copy link
Contributor Author

gmacf commented Feb 28, 2024

@sam-homa the logic here for encoding the DHCP options is basically taken from our internal DHCP server. I figured you're the most familiar with this.

@gmacf gmacf merged commit e8e8a13 into openconfig:main Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP Option encoding
3 participants